3344/rdgen
1
0
Fork 0
Code Issues 63 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Made the Docker image significantly smaller #15

Merged
nicolabelluti merged 4 commits from master into master 2025-02-01 02:06:13 +08:00
Conversation 3 Commits 4 Files Changed 4 +37 -19
nicolabelluti commented 2025-01-30 18:01:51 +08:00 (Migrated from github.com)
Copy Link
No description provided.
nicolabelluti (Migrated from github.com) reviewed 2025-01-30 18:06:18 +08:00
Dockerfile
@@ -0,0 +6,4 @@
WORKDIR /opt/rdgen
COPY . .
RUN pip install --no-cache-dir -r requirements.txt \
nicolabelluti (Migrated from github.com) commented 2025-01-30 18:06:18 +08:00
Copy Link

In a Docker container you don't need a venv

Also, line 9 in dockerfile on commit d293698e don't do anything as it opens the venv in another shell

In a Docker container you don't need a [venv](https://docs.python.org/3/library/venv.html) Also, line 9 in `dockerfile` on commit `d293698e` don't do anything as it opens the venv in another shell
bryangerlach commented 2025-02-01 00:27:10 +08:00 (Migrated from github.com)
Copy Link

Thanks for the PR, however I would like to keep the on push event of the docker_build.yml, although maybe there needs to be a separate workflow that can accept a version number (or docker tag I guess) as an input. I think this can actually just be done in the same workflow. I am fairly new to docker so if you can set this up or offer your opinion that would be awesome.

Thanks for the PR, however I would like to keep the on push event of the docker_build.yml, although maybe there needs to be a separate workflow that can accept a version number (or docker tag I guess) as an input. I think this can actually just be done in the same workflow. I am fairly new to docker so if you can set this up or offer your opinion that would be awesome.
nicolabelluti commented 2025-02-01 00:42:43 +08:00 (Migrated from github.com)
Copy Link

Let me fix it

Let me fix it
Sign in to join this conversation.
Reviewers
No Reviewers
nicolabelluti
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3344
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 3344/rdgen#15
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?