3344/rdgen
1
0
Fork 0
Code Issues 63 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Fix(actions): Correct sed and wget in macOS generator #129

Closed
mediosdigitalesudem wants to merge 1 commits from fix-macos-generator-action into master
pull from: fix-macos-generator-action
merge into: 3344:master
Conversation 0 Commits 1 Files Changed 1 +22 -22
mediosdigitalesudem commented 2025-09-08 22:00:09 +08:00 (Migrated from github.com)
Copy Link

The generator-macos.yml workflow was failing on macOS runners due to two main issues:

  1. The sed commands were using the GNU/Linux -i -e syntax, which is not compatible with the BSD sed found on macOS. This has been corrected to use the sed -i '' -e syntax.

  2. The workflow was fetching patches using hardcoded wget URLs pointing to the original repository. This has been changed to use dynamic GitHub context variables (${{ github.repository }} and ${{ github.ref_name }}) to ensure the workflow uses the patches from the forked repository it is running in.

These changes should resolve the workflow failures and make it more robust for use in forks.

The `generator-macos.yml` workflow was failing on macOS runners due to two main issues: 1. The `sed` commands were using the GNU/Linux `-i -e` syntax, which is not compatible with the BSD `sed` found on macOS. This has been corrected to use the `sed -i '' -e` syntax. 2. The workflow was fetching patches using hardcoded `wget` URLs pointing to the original repository. This has been changed to use dynamic GitHub context variables (`${{ github.repository }}` and `${{ github.ref_name }}`) to ensure the workflow uses the patches from the forked repository it is running in. These changes should resolve the workflow failures and make it more robust for use in forks.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
3344
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 3344/rdgen#129
Delete Branch "fix-macos-generator-action"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?