Small "hack" to make AutoUpdater download from custom url #145

Open
Maxetto wants to merge 3 commits from Maxetto/updater-hack into master
Maxetto commented 2025-10-21 16:22:05 +08:00 (Migrated from github.com)

Not the best approach, but as long as you have set the correct custom url for download updates and it points directly to a file it will make the new autoupdater introduced in 1.4.0 download the correct version.

Previously it would download the official unmodified version, breaking the custom values the client had.

A proper way would be to use a patch file, but I have no idea how >.<

Not the best approach, but as long as you have set the correct custom url for download updates and it points directly to a file it will make the new autoupdater introduced in 1.4.0 download the correct version. Previously it would download the official unmodified version, breaking the custom values the client had. A proper way would be to use a patch file, but I have no idea how >.<
bryangerlach commented 2025-10-25 01:51:48 +08:00 (Migrated from github.com)

Does this not work on linux or android? I haven't look into it at all. Does this change how the client checks for updates, or is it still checking based on official rustdesk versions?

Does this not work on linux or android? I haven't look into it at all. Does this change how the client checks for updates, or is it still checking based on official rustdesk versions?
Maxetto commented 2025-10-25 03:53:18 +08:00 (Migrated from github.com)

For now it seems only Windows and MacOS have this feature. Android I can confirm it still open a webpage with the url you set, Linux I don't know.
The PR that added the feature was that: https://github.com/rustdesk/rustdesk/pull/11618

It only changes the download url, all the update check logic still follows the official rustdesk versions.

For now it seems only Windows and MacOS have this feature. Android I can confirm it still open a webpage with the url you set, Linux I don't know. The PR that added the feature was that: https://github.com/rustdesk/rustdesk/pull/11618 It only changes the download url, all the update check logic still follows the official rustdesk versions.
Maxetto commented 2025-10-25 04:07:41 +08:00 (Migrated from github.com)

965cb704ec/flutter/lib/desktop/widgets/update_progress.dart (L24)
downloadUrl = '$downloadUrl/$downloadFile';

Actually maybe it could work by just replacing this line instead of messing with many lines of flutter_ffi.rs 🤔

https://github.com/rustdesk/rustdesk/blob/965cb704ecc7fcb408416949e9e68bba646d43d2/flutter/lib/desktop/widgets/update_progress.dart#L24 `downloadUrl = '$downloadUrl/$downloadFile';` Actually maybe it could work by just replacing this line instead of messing with many lines of flutter_ffi.rs 🤔
k3-cat commented 2025-11-09 12:40:34 +08:00 (Migrated from github.com)

Hi,

Sorry for open the issue #149 without checking this PR. Thanks for all your workings.
However, I feel that proposal in 149 might provide a more seamless experience yet not potentially breaks future builds as well.

If we all feel happy about it, I am more than welcome to write a git patch file or sed commands.

Hi, Sorry for open the issue #149 without checking this PR. Thanks for all your workings. However, I feel that proposal in 149 might provide a more seamless experience yet not potentially breaks future builds as well. If we all feel happy about it, I am more than welcome to write a git patch file or sed commands.
This pull request has changes conflicting with the target branch.
  • .github/workflows/generator-macos.yml
  • .github/workflows/generator-windows-x86.yml
  • .github/workflows/generator-windows.yml
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Maxetto/updater-hack:Maxetto/updater-hack
git checkout Maxetto/updater-hack
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: 3344/rdgen#145